Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DatabaseTasks adapters use DatabaseConfig objects #37291

Merged
merged 1 commit into from
Sep 25, 2019
Merged

Make DatabaseTasks adapters use DatabaseConfig objects #37291

merged 1 commit into from
Sep 25, 2019

Conversation

seejohnrun
Copy link
Member

We are moving to using DatabaseConfig objects everywhere inside of
Rails instead of passing around Hash objects.

This PR moves to using DatabaseConfig objects inside of the individual
database tasks adapters. In the interest of not breaking existing
adapters, we've introduced an upgrade path by which adapters can get a
hold of database configuration objects instead of Hashes by implementing
a method self.using_database_configurations?.

cc / @eileencodes

@seejohnrun seejohnrun force-pushed the use-database-config-objects-in-database-tasks branch 3 times, most recently from b7de700 to 9f49391 Compare September 25, 2019 16:32
@seejohnrun seejohnrun mentioned this pull request Sep 25, 2019
Merged
seejohnrun added a commit to seejohnrun/rails that referenced this pull request Sep 25, 2019
@seejohnrun @eileencodes
Update test to avoid Puma output format change
4e66e2d 
We are seeing some test failures for this test in rails#37291. It looks like
what's going on is that Puma has changed the output for this command
between 4.1 and 4.2

Previously:

```
...
* Environment: development
* Listening on tcp://localhost:3000
...

```

Now:

```
...
* Environment: development
* Listening on tcp://127.0.0.1:3000
* Listening on tcp://[::1]:3000
...

```

So to get around this, instead of checking the binding address, just
check for the presence of 'Listening' generally like we do on server
start.

Co-authored-by: eileencodes <eileencodes@gmail.com>
@seejohnrun @eileencodes
Make DatabaseTasks adapters use DatabaseConfig objects
4ee9dab 
We are moving to using `DatabaseConfig` objects everywhere inside of
Rails instead of passing around Hash objects.

This PR moves to using `DatabaseConfig` objects inside of the individual
database tasks adapters. In the interest of not breaking existing
adapters, we've introduced an upgrade path by which adapters can get a
hold of database configuration objects instead of Hashes by implementing
a method `self.using_database_configurations?`

Co-authored-by: eileencodes <eileencodes@gmail.com>
@seejohnrun seejohnrun force-pushed the use-database-config-objects-in-database-tasks branch from 9f49391 to 4ee9dab Compare September 25, 2019 17:52
carlosantoniodasilva pushed a commit that referenced this pull request Sep 25, 2019
@seejohnrun @eileencodes @carlosantoniodasilva
Update test to avoid Puma output format change
8d6da2e 
We are seeing some test failures for this test in #37291. It looks like
what's going on is that Puma has changed the output for this command
between 4.1 and 4.2

Previously:

```
...
* Environment: development
* Listening on tcp://localhost:3000
...

```

Now:

```
...
* Environment: development
* Listening on tcp://127.0.0.1:3000
* Listening on tcp://[::1]:3000
...

```

So to get around this, instead of checking the binding address, just
check for the presence of 'Listening' generally like we do on server
start.

Co-authored-by: eileencodes <eileencodes@gmail.com>
@eileencodes eileencodes merged commit cb6db15 into rails:master Sep 25, 2019
@eileencodes eileencodes deleted the use-database-config-objects-in-database-tasks branch September 25, 2019 22:33
@tagliala tagliala mentioned this pull request Dec 10, 2020
Closed
tagliala added a commit to tagliala/activerecord-postgis-adapter that referenced this pull request Dec 12, 2020
@tagliala
Add Active Record 6.1 compatibility
b6883b5 
- ActiveRecord Autoload Change: rails/rails@b744372
- Use DatabaseConfig Instead of Hash for Tasks: rails/rails#37291
- Move ActiveRecord::Tasks::DatabaseAlreadyExists to
  ActiveRecord::DatabaseAlreadyExists: rails/rails@69700c9

Close: rgeo#322, rgeo#323
@tagliala tagliala mentioned this pull request Dec 12, 2020
Merged
tagliala added a commit to tagliala/activerecord-postgis-adapter that referenced this pull request Dec 12, 2020
@tagliala
Add Active Record 6.1 compatibility
cbd12df 
- ActiveRecord Autoload Change: rails/rails@b744372
- Use DatabaseConfig Instead of Hash for Tasks: rails/rails#37291
- Move ActiveRecord::Tasks::DatabaseAlreadyExists to
  ActiveRecord::DatabaseAlreadyExists: rails/rails@69700c9
- Wrap native adapters connection errors: rails/rails#40110

Close: rgeo#322, rgeo#323
tagliala added a commit to tagliala/activerecord-postgis-adapter that referenced this pull request Dec 12, 2020
@tagliala
Add Active Record 6.1 compatibility
f0435b8 
- ActiveRecord Autoload Change: rails/rails@b744372
- Use DatabaseConfig Instead of Hash for Tasks: rails/rails#37291
- Move ActiveRecord::Tasks::DatabaseAlreadyExists to
  ActiveRecord::DatabaseAlreadyExists: rails/rails@69700c9
- Wrap native adapters connection errors: rails/rails#40110

Close: rgeo#322, rgeo#323
tagliala added a commit to tagliala/activerecord-postgis-adapter that referenced this pull request Dec 12, 2020
@tagliala
Add Active Record 6.1 compatibility
d9a8527 
- ActiveRecord Autoload Change: rails/rails@b744372
- Use DatabaseConfig Instead of Hash for Tasks: rails/rails#37291
- Move ActiveRecord::Tasks::DatabaseAlreadyExists to
  ActiveRecord::DatabaseAlreadyExists: rails/rails@69700c9
- Wrap native adapters connection errors: rails/rails#40110

Close: rgeo#322, rgeo#323
tagliala added a commit to tagliala/activerecord-postgis-adapter that referenced this pull request Dec 12, 2020
@tagliala
Add Active Record 6.1 compatibility
b3f34b1 
- ActiveRecord Autoload Change: rails/rails@b744372
- Use DatabaseConfig Instead of Hash for Tasks: rails/rails#37291
- Move ActiveRecord::Tasks::DatabaseAlreadyExists to
  ActiveRecord::DatabaseAlreadyExists: rails/rails@69700c9
- Wrap native adapters connection errors: rails/rails#40110

Close: rgeo#322, rgeo#323
tagliala added a commit to tagliala/activerecord-postgis-adapter that referenced this pull request Dec 12, 2020
@tagliala
Add Active Record 6.1 compatibility
f98375e 
- ActiveRecord Autoload Change: rails/rails@b744372
- Use DatabaseConfig Instead of Hash for Tasks: rails/rails#37291
- Move ActiveRecord::Tasks::DatabaseAlreadyExists to
  ActiveRecord::DatabaseAlreadyExists: rails/rails@69700c9
- Wrap native adapters connection errors: rails/rails#40110

Close: rgeo#322, rgeo#323
tagliala added a commit to tagliala/activerecord-postgis-adapter that referenced this pull request Dec 12, 2020
@tagliala
Add Active Record 6.1 compatibility
4bbf1c9 
- ActiveRecord Autoload Change: rails/rails@b744372
- Use DatabaseConfig Instead of Hash for Tasks: rails/rails#37291
- Move ActiveRecord::Tasks::DatabaseAlreadyExists to
  ActiveRecord::DatabaseAlreadyExists: rails/rails@69700c9
- Wrap native adapters connection errors: rails/rails#40110

Close: rgeo#322, rgeo#323
tagliala added a commit to tagliala/activerecord-postgis-adapter that referenced this pull request Dec 12, 2020
@tagliala
Add Active Record 6.1 compatibility
a8da3f7 
- ActiveRecord Autoload Change: rails/rails@b744372
- Use DatabaseConfig Instead of Hash for Tasks: rails/rails#37291
- Move ActiveRecord::Tasks::DatabaseAlreadyExists to
  ActiveRecord::DatabaseAlreadyExists: rails/rails@69700c9
- Wrap native adapters connection errors: rails/rails#40110

Close: rgeo#322, rgeo#323
tagliala added a commit to tagliala/activerecord-postgis-adapter that referenced this pull request Dec 14, 2020
@tagliala
Add Active Record 6.1 compatibility
67cf7ec 
- ActiveRecord Autoload Change: rails/rails@b744372
- Use DatabaseConfig Instead of Hash for Tasks: rails/rails#37291
- Move ActiveRecord::Tasks::DatabaseAlreadyExists to
  ActiveRecord::DatabaseAlreadyExists: rails/rails@69700c9
- Wrap native adapters connection errors: rails/rails#40110

Close: rgeo#322, rgeo#323
tagliala added a commit to tagliala/activerecord-postgis-adapter that referenced this pull request Dec 15, 2020
@tagliala
Add Active Record 6.1 compatibility
e0cc30a 
- ActiveRecord Autoload Change: rails/rails@b744372
- Use DatabaseConfig Instead of Hash for Tasks: rails/rails#37291
- Move ActiveRecord::Tasks::DatabaseAlreadyExists to
  ActiveRecord::DatabaseAlreadyExists: rails/rails@69700c9
- Wrap native adapters connection errors: rails/rails#40110

Close: rgeo#322, rgeo#323
tagliala added a commit to tagliala/activerecord-postgis-adapter that referenced this pull request Dec 17, 2020
@tagliala
Add Active Record 6.1 compatibility
983f403 
- ActiveRecord Autoload Change: rails/rails@b744372
- Use DatabaseConfig Instead of Hash for Tasks: rails/rails#37291
- Move ActiveRecord::Tasks::DatabaseAlreadyExists to
  ActiveRecord::DatabaseAlreadyExists: rails/rails@69700c9
- Wrap native adapters connection errors: rails/rails#40110

Close: rgeo#322, rgeo#323
@tagliala tagliala mentioned this pull request Dec 22, 2020
Closed
dazralsky pushed a commit to dazralsky/activerecord-postgis-adapter that referenced this pull request Aug 21, 2023
@tagliala
Add Active Record 6.1 compatibility
8175011 
- ActiveRecord Autoload Change: rails/rails@b744372
- Use DatabaseConfig Instead of Hash for Tasks: rails/rails#37291
- Move ActiveRecord::Tasks::DatabaseAlreadyExists to
  ActiveRecord::DatabaseAlreadyExists: rails/rails@69700c9
- Wrap native adapters connection errors: rails/rails#40110

Close: #322, #323
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
activerecord
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@seejohnrun @eileencodes